Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 590493002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Mac build. BUG=110610 Committed: https://crrev.com/a5171187b34bab562cc357196593310f9be41551 Cr-Commit-Position: refs/heads/master@{#295847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M content/browser/device_monitor_mac.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
6 years, 3 months ago (2014-09-19 17:02:37 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-20 01:08:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590493002/1
6 years, 3 months ago (2014-09-20 01:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590493002/1
6 years, 3 months ago (2014-09-20 01:58:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4bc48e2a165768a981bc8aab934d7faf8b99a541
6 years, 3 months ago (2014-09-20 02:26:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 02:26:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a5171187b34bab562cc357196593310f9be41551
Cr-Commit-Position: refs/heads/master@{#295847}

Powered by Google App Engine
This is Rietveld 408576698