Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2084)

Unified Diff: apps/shell_window.cc

Issue 59043013: Add flag to enable immersive fullscreen for v2 apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/shell_window.cc
diff --git a/apps/shell_window.cc b/apps/shell_window.cc
index 7eff4cea9f50ad8307c176f29f3bbcc3a8ca8a31..0f626ab21a3bab266ebc3a70197a8e881828fd7f 100644
--- a/apps/shell_window.cc
+++ b/apps/shell_window.cc
@@ -141,8 +141,7 @@ ShellWindow::ShellWindow(Profile* profile,
window_type_(WINDOW_TYPE_DEFAULT),
delegate_(delegate),
image_loader_ptr_factory_(this),
- fullscreen_for_window_api_(false),
- fullscreen_for_tab_(false),
+ fullscreen_type_(FULLSCREEN_TYPE_NONE),
show_on_first_paint_(false),
first_paint_complete_(false) {
}
@@ -404,8 +403,12 @@ void ShellWindow::Fullscreen() {
if (!profile()->GetPrefs()->GetBoolean(prefs::kAppFullscreenAllowed))
return;
#endif
- fullscreen_for_window_api_ = true;
- GetBaseWindow()->SetFullscreen(true);
+ bool tab_fullscreen =
+ (fullscreen_type_ == FULLSCREEN_TYPE_TAB ||
+ fullscreen_type_ == FULLSCREEN_TYPE_WINDOW_AND_TAB);
+ fullscreen_type_ = tab_fullscreen ?
+ FULLSCREEN_TYPE_WINDOW_AND_TAB : FULLSCREEN_TYPE_WINDOW;
+ GetBaseWindow()->SetFullscreen(fullscreen_type_);
}
void ShellWindow::Maximize() {
@@ -417,15 +420,28 @@ void ShellWindow::Minimize() {
}
void ShellWindow::Restore() {
- fullscreen_for_window_api_ = false;
- fullscreen_for_tab_ = false;
- if (GetBaseWindow()->IsFullscreenOrPending()) {
- GetBaseWindow()->SetFullscreen(false);
+ if (fullscreen_type_ != FULLSCREEN_TYPE_NONE) {
+ fullscreen_type_ = FULLSCREEN_TYPE_NONE;
+ GetBaseWindow()->SetFullscreen(fullscreen_type_);
} else {
GetBaseWindow()->Restore();
}
}
+void ShellWindow::ImmersiveFullscreen() {
+#if !defined(OS_MACOSX)
+ // Do not enter fullscreen mode if disallowed by pref.
+ if (!profile()->GetPrefs()->GetBoolean(prefs::kAppFullscreenAllowed))
+ return;
+#endif
+ if (GetBaseWindow()->SupportsImmersiveFullscreen()) {
+ fullscreen_type_ = FULLSCREEN_TYPE_IMMERSIVE;
+ GetBaseWindow()->SetFullscreen(fullscreen_type_);
+ } else {
+ Fullscreen();
+ }
+}
+
void ShellWindow::SetMinimumSize(const gfx::Size& min_size) {
size_constraints_.set_minimum_size(min_size);
OnSizeConstraintsChanged();
@@ -585,18 +601,23 @@ void ShellWindow::ToggleFullscreenModeForTab(content::WebContents* source,
return;
}
- fullscreen_for_tab_ = enter_fullscreen;
-
+ bool window_fullscreen =
+ (fullscreen_type_ == FULLSCREEN_TYPE_WINDOW ||
+ fullscreen_type_ == FULLSCREEN_TYPE_WINDOW_AND_TAB);
if (enter_fullscreen) {
- native_app_window_->SetFullscreen(true);
- } else if (!fullscreen_for_window_api_) {
- native_app_window_->SetFullscreen(false);
+ fullscreen_type_ = window_fullscreen ?
+ FULLSCREEN_TYPE_WINDOW_AND_TAB : FULLSCREEN_TYPE_TAB;
+ } else {
+ fullscreen_type_ = window_fullscreen ?
+ FULLSCREEN_TYPE_WINDOW : FULLSCREEN_TYPE_NONE;
}
+ GetBaseWindow()->SetFullscreen(fullscreen_type_);
}
bool ShellWindow::IsFullscreenForTabOrPending(
const content::WebContents* source) const {
- return fullscreen_for_tab_;
+ return (fullscreen_type_ == FULLSCREEN_TYPE_TAB ||
+ fullscreen_type_ == FULLSCREEN_TYPE_WINDOW_AND_TAB);
}
void ShellWindow::Observe(int type,
« no previous file with comments | « apps/shell_window.h ('k') | apps/ui/native_app_window.h » ('j') | ash/ash_switches.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698