Add flag to enable immersive fullscreen for v2 apps

ash/wm/custom_frame_view_ash.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_CUSTOM_FRAME_VIEW_ASH_H_
 #define ASH_WM_CUSTOM_FRAME_VIEW_ASH_H_
 
 #include "ash/ash_export.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/views/window/non_client_view.h"
 
 namespace ash {
 class FrameBorderHitTestController;
 class HeaderPainter;
+class ImmersiveFullscreenController;
 }
 namespace gfx {
 class Font;
 }
 namespace views {
 class Widget;
 }
 
 namespace ash {
 
 class FrameCaptionButtonContainerView;
 
-// A NonClientFrameView used for dialogs and other non-browser windows.
+// A NonClientFrameView which supports immersive fullscreen which is used for
+// packaged apps, dialogs and other non-browser windows. When in immersive

[oshima, 2013/11/08 23:25:32]

Can you rephrase so that whether or not this is used depends on the
WindowStateDelegate::EnterFullscreen implementation, and cros uses this for
packaged apps, and non browser windows (but not on win8)?

+// fullscreen, the client view takes up the entire widget and the window header
+// is an overlay. The window header overlay slides onscreen when the user hovers
+// the mouse at the top of the screen.
 // See also views::CustomFrameView and BrowserNonClientFrameViewAsh.
 class ASH_EXPORT CustomFrameViewAsh : public views::NonClientFrameView {
  public:
   // Internal class name.
   static const char kViewClassName[];
 
   explicit CustomFrameViewAsh(views::Widget* frame);
   virtual ~CustomFrameViewAsh();
 
+  // Inits |immersive_fullscreen_controller| so that the controller reveals
+  // and hides |header_view_| in immersive fullscreen.

[oshima, 2013/11/08 23:25:32]

can you mention ownership?

+  void InitImmersiveFullscreenControllerForView(
+      ImmersiveFullscreenController* immersive_fullscreen_controller);
+
   // views::NonClientFrameView overrides:
   virtual gfx::Rect GetBoundsForClientView() const OVERRIDE;
   virtual gfx::Rect GetWindowBoundsForClientBounds(
       const gfx::Rect& client_bounds) const OVERRIDE;
   virtual int NonClientHitTest(const gfx::Point& point) OVERRIDE;
   virtual void GetWindowMask(const gfx::Size& size,
                              gfx::Path* window_mask) OVERRIDE;
   virtual void ResetWindowControls() OVERRIDE;
   virtual void UpdateWindowIcon() OVERRIDE;
   virtual void UpdateWindowTitle() OVERRIDE;
+  virtual void ShouldPaintAsActiveChanged() OVERRIDE;
 
   // views::View overrides:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
-  virtual void Layout() OVERRIDE;
   virtual const char* GetClassName() const OVERRIDE;
-  virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
   virtual gfx::Size GetMinimumSize() OVERRIDE;
   virtual gfx::Size GetMaximumSize() OVERRIDE;
+  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
 
  private:
+  class OverlayView;
+
   // Height from top of window to top of client area.
   int NonClientTopBorderHeight() const;
 
   // Not owned.
   views::Widget* frame_;
 
-  // View which contains the window controls.
-  FrameCaptionButtonContainerView* caption_button_container_;
-
-  // Helper class for painting the header.
-  scoped_ptr<HeaderPainter> header_painter_;
+  // View which contains the title and window controls.
+  class HeaderView;
+  HeaderView* header_view_;
 
   // Updates the hittest bounds overrides based on the window show type.
   scoped_ptr<FrameBorderHitTestController> frame_border_hit_test_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(CustomFrameViewAsh);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_CUSTOM_FRAME_VIEW_ASH_H_