Add flag to enable immersive fullscreen for v2 apps

ash/ash_switches.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ASH_SWITCHES_H_
 #define ASH_ASH_SWITCHES_H_
 
 #include "ash/ash_export.h"
 
 #include "build/build_config.h"
@@ skipping 25 matching lines @@
 ASH_EXPORT extern const char kAshDisableDragOffShelf[];
 ASH_EXPORT extern const char kAshDisableOverviewMode[];
 ASH_EXPORT extern const char kAshDisableDragAndDropAppListToLauncher[];
 #if defined(OS_CHROMEOS)
 ASH_EXPORT extern const char kAshDisableUsbChargerNotification[];
 ASH_EXPORT extern const char kAshEnableAudioDeviceMenu[];
 #endif
 ASH_EXPORT extern const char kAshEnableAdvancedGestures[];
 ASH_EXPORT extern const char kAshEnableAlternateFrameCaptionButtonStyle[];
 ASH_EXPORT extern const char kAshEnableBrightnessControl[];
+ASH_EXPORT extern const char kAshEnableAppImmersiveFullscreen[];

[oshima, 2013/11/08 23:25:32]

chrome/common/chrome_switches?

[pkotwicz, 2013/11/09 00:09:02]

I am keeping it here. In terms of precedent, --ash-enable-immersive-fullscreen
was also in ash_switches.h (See https://chromiumcodereview.appspot.com/14366004)

[oshima, 2013/11/09 01:11:18]

That flag shouldn't have been in ash first place IMO. Flag should be in the
component where the feature is toggled.

[pkotwicz, 2013/11/13 00:10:13]

We unfortunately need to keep the flag in ash. I will need to use it (from
CustomFrameViewAsh) in order to implement putting non-app windows like the task
manager into immersive fullscreen.
I plan on implementing this via a custom WindowStateDelegate if
|WindowState::delegate_| is non-NULL

I have renamed the flag to kAshEnableImmersiveFullscreenForAllWindows to make
its intent clearer

[oshima, 2013/11/13 07:21:36]

Ok.

 #if defined(OS_CHROMEOS)
 ASH_EXPORT extern const char kAshEnableFullMultiProfileMode[];
 #endif
 #if defined(OS_LINUX)
 ASH_EXPORT extern const char kAshEnableMemoryMonitor[];
 #endif
 ASH_EXPORT extern const char kAshEnableOak[];
 ASH_EXPORT extern const char kAshEnableSoftwareMirroring[];
 ASH_EXPORT extern const char kAshEnableStickyEdges[];
 ASH_EXPORT extern const char kAshEnableTrayDragging[];
@@ skipping 47 matching lines @@
 
 // Returns true if a notification should appear when a low-power USB charger
 // is connected.
 ASH_EXPORT bool UseUsbChargerNotification();
 #endif
 
 }  // namespace switches
 }  // namespace ash
 
 #endif  // ASH_ASH_SWITCHES_H_