Add flag to enable immersive fullscreen for v2 apps

chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h"
 
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "base/command_line.h"
 #include "base/mac/mac_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 409 matching lines @@
 }
 
 bool NativeAppWindowCocoa::IsMinimized() const {
   return [window() isMiniaturized];
 }
 
 bool NativeAppWindowCocoa::IsFullscreen() const {
   return is_fullscreen_;
 }
 
-void NativeAppWindowCocoa::SetFullscreen(bool fullscreen) {
+void NativeAppWindowCocoa::SetFullscreen(ShellWindow::FullscreenType type) {

[oshima, 2013/11/07 18:56:13]

Is it worth DCHECKing not immersive here?

[pkotwicz, 2013/11/07 22:21:48]

Personally, I would rather skip the DCHECK() given that
NativeAppWindowCocoa::SupportsImmersiveFullscreen() returns false

+  bool fullscreen = (type != ShellWindow::FULLSCREEN_TYPE_NONE);
   if (fullscreen == is_fullscreen_)
     return;
   is_fullscreen_ = fullscreen;
 
   if (base::mac::IsOSLionOrLater()) {
     // If going fullscreen, but the window is constrained (fullscreen UI control
     // is disabled), temporarily enable it. It will be disabled again on leaving
     // fullscreen.
     if (fullscreen && !shows_fullscreen_controls_)
       SetFullScreenCollectionBehavior(window(), true);
@@ skipping 35 matching lines @@
   InstallView();
 
   // Fade back in.
   if (did_fade_out) {
     CGDisplayFade(token, kFadeDurationSeconds / 2, kCGDisplayBlendSolidColor,
         kCGDisplayBlendNormal, 0.0, 0.0, 0.0, /*synchronous=*/false);
     CGReleaseDisplayFadeReservation(token);
   }
 }
 
-bool NativeAppWindowCocoa::IsFullscreenOrPending() const {
-  return is_fullscreen_;
+bool NativeAppWindowCocoa::SupportsImmersiveFullscreen() const {
+  return false;
 }
 
 bool NativeAppWindowCocoa::IsDetached() const {
   return false;
 }
 
 gfx::NativeWindow NativeAppWindowCocoa::GetNativeWindow() {
   return window();
 }
 
@@ skipping 66 matching lines @@
   UpdateRestoredBounds();
   is_maximized_ = true;  // See top of file NOTE: State Before Update.
   [window() setFrame:[[window() screen] visibleFrame] display:YES animate:YES];
 }
 
 void NativeAppWindowCocoa::Minimize() {
   [window() miniaturize:window_controller_];
 }
 
 void NativeAppWindowCocoa::Restore() {
-  DCHECK(!IsFullscreenOrPending());   // SetFullscreen, not Restore, expected.
+  DCHECK(!is_fullscreen_);   // SetFullscreen, not Restore, expected.
 
   if (IsMaximized()) {
     is_maximized_ = false;  // See top of file NOTE: State Before Update.
     [window() setFrame:restored_bounds() display:YES animate:YES];
   } else if (IsMinimized()) {
     is_maximized_ = false;  // See top of file NOTE: State Before Update.
     [window() deminiaturize:window_controller_];
   }
 }
 
@@ skipping 424 matching lines @@
   [window() setContentMinSize:NSMakeSize(min_size.width(), min_size.height())];
 
   gfx::Size max_size = shell_window_->size_constraints().GetMaximumSize();
   const int kUnboundedSize = ShellWindow::SizeConstraints::kUnboundedSize;
   CGFloat max_width = max_size.width() == kUnboundedSize ?
       CGFLOAT_MAX : max_size.width();
   CGFloat max_height = max_size.height() == kUnboundedSize ?
       CGFLOAT_MAX : max_size.height();
   [window() setContentMaxSize:NSMakeSize(max_width, max_height)];
 }