Add flag to enable immersive fullscreen for v2 apps

ash/wm/window_state_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_STATE_DELEGATE_H_
 #define ASH_WM_WINDOW_STATE_DELEGATE_H_
 
 #include "ash/ash_export.h"
 #include "base/basictypes.h"
 
 namespace ash {
 namespace wm {
 class WindowState;
 
 class ASH_EXPORT WindowStateDelegate {
  public:
   WindowStateDelegate();
   virtual ~WindowStateDelegate();
 
-  // Invoked when the user uses Shift+F4/F4 to toggle the window
-  // fullscreen state.  The caller (ash::wm::WindowState) falls backs
-  // to the default implementation if this returns false.
-  virtual bool ToggleFullscreen(WindowState* window_state);
+  // Enters immersive fullscreen or regular fullscreen depending on whether
+  // immersive fullscreen is supported by the window. This is a no-op if the
+  // window is already in non-immersive fullscreen. The caller
+  // (ash::wm::WindowState) falls back to the default implementation if this
+  // returns false.
+  virtual bool EnterImmersiveFullscreen(WindowState* window_state);

[oshima, 2013/11/07 18:56:13]

I still think we should call EnterFullscreen because it may or may not go
ImmersiveFullscreen, and ImmersiveFullscreen is a variant of Fullscreen, but not
the other way around.

[pkotwicz, 2013/11/07 22:21:48]

The reason that I want to call this EnterImmersiveFullscreen() is that the
method enters immersive fullscreen if possible. It does not enter fullscreen
with the window's "default" fullscreen type. FULLSCREEN_TYPE_WINDOW is the
"default" fullscreen type for v2 apps.

[oshima, 2013/11/08 00:26:29]

But it doesn't enter ImmersiveFullscreen when not possible either right?

[pkotwicz, 2013/11/08 01:16:57]

I can split EnterImmersiveFullscreen() into two methods:
EnterImmersiveFullscreen() and EnterDefaultFullscreen()/EnterFullscreen() if
that would make things clearer.

+
+  // Exits fullscreen and retores the window's state before it was fullscreen.
+  // The caller (ash::wm::WindowState) falls back to the default implementation
+  // if this returns false.
+  virtual bool ExitFullscreen(WindowState* window_state);

[oshima, 2013/11/07 18:56:13]

Thanks, I'll look into restoring from fullscreen state.

 
  private:
   DISALLOW_COPY_AND_ASSIGN(WindowStateDelegate);
 };
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_WM_WINDOW_STATE_DELEGATE_H_