Add flag to enable immersive fullscreen for v2 apps

apps/ui/native_app_window.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef APPS_UI_NATIVE_APP_WINDOW_H_
 #define APPS_UI_NATIVE_APP_WINDOW_H_
 
 #include "apps/shell_window.h"
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "ui/base/base_window.h"
 #include "ui/gfx/insets.h"
 
 namespace apps {
 
 // This is an interface to a native implementation of a shell window, used for
 // new-style packaged apps. Shell windows contain a web contents, but no tabs
 // or URL bar.
 class NativeAppWindow : public ui::BaseWindow,
                         public web_modal::WebContentsModalDialogHost {
  public:
-  // Fullscreen changes may be asynchronous on some platforms.
-  virtual void SetFullscreen(bool fullscreen) = 0;
-  virtual bool IsFullscreenOrPending() const = 0;
+  // Sets whether the window is fullscreen and the type of fullscreen.
+  virtual void SetFullscreen(ShellWindow::FullscreenType type) = 0;
+
+  // Returns true if the window supports immersive fullscreen.

[benwells, 2013/11/13 07:41:27]

Maybe this is bikeshedding, but 'immersive fullscreen' feels like a tautology.
Is there non-immersive fullscreen?

[pkotwicz, 2013/11/13 22:06:01]

I agree that immersive fullscreen is not a good name, especially given that
immersive fullscreen is less immersive than "traditional/normal fullscreen.
There is a historical reason why we use the name, but eventually we should
probably rename the feature.

+  virtual bool SupportsImmersiveFullscreen() const = 0;
 
   // Returns true if the window is a panel that has been detached.
   virtual bool IsDetached() const = 0;
 
   // Called when the icon of the window changes.
   virtual void UpdateWindowIcon() = 0;
 
   // Called when the title of the window changes.
   virtual void UpdateWindowTitle() = 0;
 
@@ skipping 30 matching lines @@
   // Updates the minimum and maximum size of the native window with the current
   // size constraints.
   virtual void UpdateWindowMinMaxSize() = 0;
 
   virtual ~NativeAppWindow() {}
 };
 
 }  // namespace apps
 
 #endif  // APPS_UI_NATIVE_APP_WINDOW_H_