Add flag to enable immersive fullscreen for v2 apps

apps/app_window_contents.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/app_window_contents.h"
 
 #include "apps/ui/native_app_window.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/app_window.h"
@@ skipping 76 matching lines @@
   DictionaryValue* dictionary = new DictionaryValue();
   args.Append(dictionary);
 
   gfx::Rect bounds = host_->GetClientBounds();
   app_window::Bounds update;
   update.left.reset(new int(bounds.x()));
   update.top.reset(new int(bounds.y()));
   update.width.reset(new int(bounds.width()));
   update.height.reset(new int(bounds.height()));
   dictionary->Set("bounds", update.ToValue().release());
-  dictionary->SetBoolean("fullscreen",
-                         native_app_window->IsFullscreenOrPending());
+  dictionary->SetBoolean("alwaysOnTop", native_app_window->IsAlwaysOnTop());
   dictionary->SetBoolean("minimized", native_app_window->IsMinimized());
-  dictionary->SetBoolean("maximized", native_app_window->IsMaximized());
-  dictionary->SetBoolean("alwaysOnTop", native_app_window->IsAlwaysOnTop());
+
+  bool maximized = native_app_window->IsMaximized();
+  ShellWindow::FullscreenType fullscreen_type = host_->fullscreen_type();
+  // Check both the fullscreen type and |native_app_window| so that the window
+  // is reported as fullscreen if |native_app_window|'s fullscreen state lags
+  // behind that of ShellWindow. (This is the case in the GTK port).
+  bool fullscreen = (fullscreen_type != ShellWindow::FULLSCREEN_TYPE_NONE) ||
+      native_app_window->IsFullscreen();
+  if (fullscreen_type == ShellWindow::FULLSCREEN_TYPE_IMMERSIVE) {
+    // A window in immersive fullscreen on ChromeOS does not take up all of the
+    // pixels on screen because the shelf is auto hidden, not completely hidden.
+    // For this reason, immersive fullscreen windows are considered maximized
+    // for the sake of the app.window api.

[pkotwicz, 2013/11/13 00:10:13]

I am not sure whether telling the app that we are not fullscreen when in
immersive fullscreen is worth it.
With the code as is, chrome.app.window.current().maximize() exits immersive
fullscreen, so I should probably fix that.

benwells@, what do you think?

[benwells, 2013/11/13 07:41:27]

I think it is probably full screen enough to say it is fullsceen. If it isn't,
we shouldn't have a FULLSCREEN_TYPE_IMMERSIVE but should do it some other way.

Why did you remove IsFullscreenOrPending? Was it only used here? I'm not super
familiar with this, but can you replace this call to just:
fullscreen = fullscreen_type != ShellWindow::FULLSCREEN_TYPE_NONE? That is, do
you need to check with the native_app_window at all?

[pkotwicz, 2013/11/13 22:06:01]

IsFullscreenOrPending() is back. I removed it in the previous CL because there
was starting to be many fullscreen related methods in NativeAppWindow.

I changed |fullscreen_type| to be a bit field. This allows all of the fullscreen
types to be combined together.
This allows a user to be in both OS fullscreen and HTML fullscreen which we
allow for browser windows as well.

+    fullscreen = false;
+    maximized = true;
+  }
+  dictionary->SetBoolean("fullscreen", fullscreen);
+  dictionary->SetBoolean("maximized", maximized);
 
   const ShellWindow::SizeConstraints& size_constraints =
       host_->size_constraints();
   gfx::Size min_size = size_constraints.GetMinimumSize();
   gfx::Size max_size = size_constraints.GetMaximumSize();
   if (min_size.width() != kUnboundedSize)
     dictionary->SetInteger("minWidth", min_size.width());
   if (min_size.height() != kUnboundedSize)
     dictionary->SetInteger("minHeight", min_size.height());
   if (max_size.width() != kUnboundedSize)
@@ skipping 75 matching lines @@
     content::RenderViewHost* rvh) {
   DCHECK(rvh);
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&content::ResourceDispatcherHost::BlockRequestsForRoute,
                  base::Unretained(content::ResourceDispatcherHost::Get()),
                  rvh->GetProcess()->GetID(), rvh->GetRoutingID()));
 }
 
 }  // namespace apps