Issue 590413005: Move paint code from RenderListMarker/RenderListItem to ListMarkerPainter/ListItemPainter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 590413005: Move paint code from RenderListMarker/RenderListItem to ListMarkerPainter/ListItemPainter. (Closed)

Created:
6 years, 3 months ago by chrishtr

Modified:
6 years, 3 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1, slimming-paint-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move paint code from RenderListMarker/RenderListItem to ListMarkerPainter/ListItemPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182530

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+266 lines, -216 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	Source/core/paint/ListItemPainter.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
A	Source/core/paint/ListItemPainter.cpp	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A +	Source/core/paint/ListMarkerPainter.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
A	Source/core/paint/ListMarkerPainter.cpp	View	1 chunk	+214 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderListMarker.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderListMarker.cpp	View	3 chunks	+3 lines, -198 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590413005/1

6 years, 3 months ago (2014-09-23 22:49:42 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 00:14:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182530

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages