Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 590403003: Roll breakpad a513e85:7caf028 (svn 1384:1385) (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad a513e85:7caf028 (svn 1384:1385) r1385: Linux: Call memset() in a couple places in ExceptionHandler. BUG=332335 Committed: https://crrev.com/ec86bac94da60dc9286bb49b87745570a83a6a55 Cr-Commit-Position: refs/heads/master@{#296446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-24 02:13:48 UTC) #2
Timur Iskhodzhanov
Roll LGTM There are a few comments on the original change though: - Typo: "This ...
6 years, 3 months ago (2014-09-24 13:59:30 UTC) #3
Lei Zhang
On 2014/09/24 13:59:30, Timur Iskhodzhanov wrote: > Roll LGTM Thanks > There are a few ...
6 years, 3 months ago (2014-09-24 17:07:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590403003/1
6 years, 3 months ago (2014-09-24 17:08:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 07fba0944628eef41ca83d304723ffa67f635807
6 years, 3 months ago (2014-09-24 17:12:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec86bac94da60dc9286bb49b87745570a83a6a55 Cr-Commit-Position: refs/heads/master@{#296446}
6 years, 3 months ago (2014-09-24 17:12:59 UTC) #8
Lei Zhang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/595343003/ by thestig@chromium.org. ...
6 years, 3 months ago (2014-09-24 17:56:12 UTC) #9
Nico
6 years, 3 months ago (2014-09-24 17:59:02 UTC) #10
Message was sent while issue was closed.
(This is probably broken on tsan due to it using libc++ instead of libstdc++;
you likely just need to add a few more includes to make things go)

Powered by Google App Engine
This is Rietveld 408576698