Issue 59033010: Initial support for /privet/printer/createjob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59033010: Initial support for /privet/printer/createjob (Closed)

Created:
7 years, 1 month ago by Noam Samuel

Modified:
7 years, 1 month ago

Reviewers:
gene, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Initial support for /privet/printer/createjob Support /privet/printer/createjob. Currently does not correctly fall back for all error conditions. Also, simplify PrivetLocalPrinterOperation by removing the callback for current request (since it was used only by the retry system, which was moved to PrivetURLFetcher). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233451

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -21 lines)			Patch
M	chrome/browser/local_discovery/privet_http_impl.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_http_impl.cc	View	10 chunks	+38 lines, -16 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_http_unittest.cc	View	3 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/59033010/1

7 years, 1 month ago (2013-11-06 19:47:04 UTC) #3

Message was sent while issue was closed.

Change committed as 233451

Expand Messages | Collapse Messages