Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 590313004: Revert of Fix bad scaling in TiledLayer (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 3 months ago
Reviewers:
danakj, sky
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix bad scaling in TiledLayer (patchset #8 id:140001 of https://codereview.chromium.org/567743003/) Reason for revert: This break Blink layout tests. See crbug.com/416775. Original issue's description: > Fix bad scaling in TiledLayer > > On the windows side (and likely chromeos for some devices) we can end > up in a situation where the pixel bounds is not an even multiple of the > scale factor. This means when TiledLayer calculates the scale it ends > up off. > > BUG=416655 > TEST=added test coverage > R=danakj@chromium.org > > Committed: https://crrev.com/c01746b4f7d811a5fdc75ce6570a9667b9877913 > Cr-Commit-Position: refs/heads/master@{#296108} TBR=danakj@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=416655 Committed: https://crrev.com/fcd74526865d5d0d127361c26459e1c0a5e16afc Cr-Commit-Position: refs/heads/master@{#296158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -162 lines) Patch
M cc/layers/content_layer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/tiled_layer.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 6 chunks +5 lines, -38 lines 0 comments Download
M cc/resources/bitmap_content_layer_updater.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/bitmap_content_layer_updater.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M cc/resources/bitmap_skpicture_content_layer_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/content_layer_updater.h View 3 chunks +3 lines, -11 lines 0 comments Download
M cc/resources/content_layer_updater.cc View 5 chunks +11 lines, -53 lines 0 comments Download
M cc/resources/layer_updater.h View 3 chunks +1 line, -4 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M cc/test/fake_content_layer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 3 chunks +1 line, -6 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
Created Revert of Fix bad scaling in TiledLayer
6 years, 3 months ago (2014-09-23 08:28:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590313004/1
6 years, 3 months ago (2014-09-23 08:29:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as bd16dcfa48462f90e90518e8495663ea60e18bc6
6 years, 3 months ago (2014-09-23 08:30:55 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 08:31:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcd74526865d5d0d127361c26459e1c0a5e16afc
Cr-Commit-Position: refs/heads/master@{#296158}

Powered by Google App Engine
This is Rietveld 408576698