Chromium Code Reviews
Help | Chromium Project | Sign in
(162)

Issue 5903005: The URLRequestContext for off-the-record mode should... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
agl, Nirnimesh
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

The URLRequestContext for off-the-record mode should
have a non-NULL cert_verifier, otherwise SSLClientSocket
in off-the-record mode will crash when verifying a
certificate. Just share the same cert verifier with the
original profile.

R=agl,nirnimesh
BUG=63357
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69478

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Lint Patch
M chrome/browser/net/chrome_url_request_context.cc View 1 chunk +3 lines, -2 lines 1 comment 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
wtc
3 years, 4 months ago #1
Nirnimesh
LGTM
3 years, 4 months ago #2
wtc
3 years, 4 months ago #3
http://codereview.chromium.org/5903005/diff/1/chrome/browser/net/chrome_url_r...
File chrome/browser/net/chrome_url_request_context.cc (right):

http://codereview.chromium.org/5903005/diff/1/chrome/browser/net/chrome_url_r...
chrome/browser/net/chrome_url_request_context.cc:408:
context->set_cert_verifier(original_context->cert_verifier());
agl: I noticed that you don't copy original_context->dnsrr_resolver()
here, and you pass NULL as dns_cert_checker to
new net::HttpCache() at line 420 below.

Is that intentional or an oversight?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6