util/numeric/int128.h - Issue 590283002: uint128_struct: address misunderstood review feedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/numeric/int128.h

Issue 590283002: uint128_struct: address misunderstood review feedback (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/numeric/int128.h

diff --git a/util/numeric/int128.h b/util/numeric/int128.h

index 7335e77514e2affd7e62ad9272726cda14ac1fc9..75b8b6a8db10fcb8d2ff4e8f2bde3acf801e40e0 100644

--- a/util/numeric/int128.h

+++ b/util/numeric/int128.h

@@ -17,6 +17,7 @@

#include <stdint.h>

+#include "base/basictypes.h"

#include "build/build_config.h"

namespace crashpad {

@@ -45,6 +46,8 @@ struct uint128_struct {

#endif

};

+COMPILE_ASSERT(sizeof(uint128_struct) == 16, uint128_must_be_16_bytes);

} // namespace crashpad

#endif // CRASHPAD_UTIL_NUMERIC_INT128_H_

« no previous file with comments | « no previous file | util/numeric/int128_test.cc » ('j') | no next file with comments »