Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 590243002: Revert of Move content_gl_tests.isolate to content. (Closed)

Created:
6 years, 3 months ago by Jamie Madill
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org, Ian Vollick, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Move content_gl_tests.isolate to content. (patchset #8 id:240001 of https://codereview.chromium.org/573073003/) Reason for revert: Failing bot in content_gl_tests, see http://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/22782 Original issue's description: > Move content_gl_tests.isolate to content. > > I noticed this while looking through isolate files. Since the test target is in content, the isolate file should be alongside. > > Committed: https://crrev.com/1351139b75882cf05417aa615df21d641870be3c > Cr-Commit-Position: refs/heads/master@{#295983} TBR=kbr@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -83 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/content_gl_tests.isolate View 1 chunk +34 lines, -0 lines 0 comments Download
D content/content_gl_tests.isolate View 1 chunk +0 lines, -56 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jamie Madill
Created Revert of Move content_gl_tests.isolate to content.
6 years, 3 months ago (2014-09-22 18:54:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590243002/1
6 years, 3 months ago (2014-09-22 18:55:16 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-22 18:55:18 UTC) #4
Ken Russell (switch to Gerrit)
6 years, 3 months ago (2014-09-22 19:17:32 UTC) #5
Since the original CL passed the commit queue it doesn't seem appropriate to
revert it. We'll figure out what's going on with the component builds on Windows
7. Closing this CL.

Powered by Google App Engine
This is Rietveld 408576698