src/typedarray.js - Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typedarray.js

Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typedarray.js

diff --git a/src/typedarray.js b/src/typedarray.js

index fc3a608f46ff83afd30b4b1108ac1f24e2419602..ed9de23b50e1a6a4b7b3cb06948ac24cf4881d0b 100644

--- a/src/typedarray.js

+++ b/src/typedarray.js

@@ -78,7 +78,8 @@ macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)

var newLength = ToPositiveInteger(length, "invalid_typed_array_length");

newByteLength = newLength * ELEMENT_SIZE;

}

- if (offset + newByteLength > bufferByteLength) {

+ if ((offset + newByteLength > bufferByteLength)

+ || (newLength > %MaxSmi())) {

throw MakeRangeError("invalid_typed_array_length");

}

%TypedArrayInitialize(obj, ARRAY_ID, buffer, offset, newByteLength);