src/property-details.h - Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/property-details.h

Issue 59023003: Generate TypedArrayInitialize builtin in hydrogen. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/property-details.h

diff --git a/src/property-details.h b/src/property-details.h

index 36f140681fe8d5ab916bd3bb1ccfa1b8ad68bd06..617e9b2af76ff3e9aa6ab9a273c1783866bd4b3a 100644

--- a/src/property-details.h

+++ b/src/property-details.h

@@ -131,6 +131,10 @@ class Representation {

}

bool is_more_general_than(const Representation& other) const {

+ if (kind_ == kExternal && other.kind_ == kNone) return true;

+ if (kind_ == kExternal && other.kind_ == kExternal) return false;

+ if (kind_ == kNone && other.kind_ == kExternal) return false;

ASSERT(kind_ != kExternal);

ASSERT(other.kind_ != kExternal);

if (IsHeapObject()) return other.IsDouble() || other.IsNone();