Source/core/xml/parser/XMLDocumentParser.cpp - Issue 590193002: Use xmlnsWithColon instead of literal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.cpp

Issue 590193002: Use xmlnsWithColon instead of literal (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/parser/XMLDocumentParser.cpp

diff --git a/Source/core/xml/parser/XMLDocumentParser.cpp b/Source/core/xml/parser/XMLDocumentParser.cpp

index 21545a81d4800a3b9498283d90811220890c1c3c..7aac8b15ff0d29d9631f5d20e5f63999d7b5e676 100644

--- a/Source/core/xml/parser/XMLDocumentParser.cpp

+++ b/Source/core/xml/parser/XMLDocumentParser.cpp

@@ -915,7 +915,7 @@ static inline void handleNamespaceAttributes(Vector<Attribute>& prefixedAttribut

AtomicString namespaceQName = xmlnsAtom;

AtomicString namespaceURI = toAtomicString(namespaces[i].uri);

if (namespaces[i].prefix)

- namespaceQName = "xmlns:" + toString(namespaces[i].prefix);

+ namespaceQName = WTF::xmlnsWithColon + toString(namespaces[i].prefix);

adamk 2014/09/22 18:33:05 You can get rid of the toString() call on the righ

QualifiedName parsedName = anyName;

if (!Element::parseAttributeName(parsedName, XMLNSNames::xmlnsNamespaceURI, namespaceQName, exceptionState))

« no previous file with comments | « no previous file | no next file » | no next file with comments »