Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 590193002: Use xmlnsWithColon instead of literal (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use xmlnsWithColon instead of literal We can just use the existing global xmlnsWithColon and avoid a potential strlen on the literal. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182444

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-22 16:06:13 UTC) #2
adamk
lgtm, seems fine. https://codereview.chromium.org/590193002/diff/1/Source/core/xml/parser/XMLDocumentParser.cpp File Source/core/xml/parser/XMLDocumentParser.cpp (right): https://codereview.chromium.org/590193002/diff/1/Source/core/xml/parser/XMLDocumentParser.cpp#newcode918 Source/core/xml/parser/XMLDocumentParser.cpp:918: namespaceQName = WTF::xmlnsWithColon + toString(namespaces[i].prefix); You ...
6 years, 3 months ago (2014-09-22 18:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590193002/20001
6 years, 3 months ago (2014-09-22 18:44:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 20:01:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182444

Powered by Google App Engine
This is Rietveld 408576698