Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/signin/core/browser/signin_metrics.h

Issue 590113004: Handle account removal correctly on all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify metrics Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_metrics.h
diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h
index 3d8832e58b79b4bbce9d7a46ad84e052f8077b25..a8bf1e22118aa0aee8617d922c6c136bc0e96140 100644
--- a/components/signin/core/browser/signin_metrics.h
+++ b/components/signin/core/browser/signin_metrics.h
@@ -53,9 +53,9 @@ enum ProfileSignout {
// |total_number_accounts| - How many accounts are in the browser for this
// profile.
// |count_added_to_cookie_jar| - How many accounts were in the browser but not
-// the cookie jar.
-// |count_added_to_token| - How may accounts were in the cookie jar but not in
-// the browser.
+// in the cookie jar.
Mike Lerman 2014/09/23 14:27:47 Nit: add a space to left-align the comments
Roger Tawa OOO till Jul 10th 2014/09/23 21:25:59 Done.
+// |count_removed_from_cookie_jar| - How many accounts were in the cookie jar
+// but not in the browser.
// |primary_accounts_same| - False if the primary account for the cookie jar
// and the token service were different; else true.
// |is_first_reconcile| - True if these stats are from the first execution of
@@ -64,7 +64,7 @@ enum ProfileSignout {
// the AccountReconcilor began modifying the state.
void LogSigninAccountReconciliation(int total_number_accounts,
int count_added_to_cookie_jar,
- int count_added_to_token,
+ int count_removed_from_cookie_jar,
bool primary_accounts_same,
bool is_first_reconcile,
int pre_count_gaia_cookies);

Powered by Google App Engine
This is Rietveld 408576698