Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 590073002: Gallery: Fix a beginning position gap of cropping. (Closed)

Created:
6 years, 3 months ago by hirono
Modified:
6 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gallery: Fix a beginning position gap of cropping. The gap occures when a user moves the mouse cursor fast at the beginning of cropping. The reason the app uses the first mousemove event's coordinate as the beginning position of cropping. The CL uses the mousedown event's coordinate instead of the first mousemove's one. BUG=412237 TEST=manually Committed: https://crrev.com/3b3280d7204d567d4d27c7966782e2d17adcf123 Cr-Commit-Position: refs/heads/master@{#295945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/gallery/js/image_editor/image_transform.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thank you!
6 years, 3 months ago (2014-09-22 08:05:50 UTC) #2
mtomasz
lgtm
6 years, 3 months ago (2014-09-22 09:27:05 UTC) #3
hirono
On 2014/09/22 09:27:05, mtomasz wrote: > lgtm Thanks!
6 years, 3 months ago (2014-09-22 09:29:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590073002/1
6 years, 3 months ago (2014-09-22 09:30:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 097d7cdd79e1a4f369e3c26d3feeca36a5250831
6 years, 3 months ago (2014-09-22 10:01:50 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 10:02:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b3280d7204d567d4d27c7966782e2d17adcf123
Cr-Commit-Position: refs/heads/master@{#295945}

Powered by Google App Engine
This is Rietveld 408576698