Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 590043002: [ServiceWorker] Treat the rejected result of onFetch event as a Network Error. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Treat the rejected result of onFetch event as a Network Error. In current code the rejected result of onFetch event is treated as 500 respose. But it should be treated as a Network Error. Step1: [ServiceWorker] Remove the test for the rejected result of FetchEvent from fetch-event.html https://codereview.chromium.org/588993002/ Step2: this patch [ServiceWorker] Treat the rejected result of onFetch as a Network Error. https://codereview.chromium.org/590043002/ Step3: [ServiceWorker] Add test for the rejected result of FetchEvent using XHR. https://codereview.chromium.org/588093003/ BUG=411173 Committed: https://crrev.com/8faf94721b6ec90f92404234f0c227e2e501c102 Cr-Commit-Position: refs/heads/master@{#296080}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
horo
yhirano@ Could you please review?
6 years, 3 months ago (2014-09-22 05:29:33 UTC) #3
yhirano
lgtm https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc#newcode384 content/browser/service_worker/service_worker_url_request_job.cc:384: // Treat a response whose status is 0 ...
6 years, 3 months ago (2014-09-22 07:42:35 UTC) #4
horo
https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc#newcode384 content/browser/service_worker/service_worker_url_request_job.cc:384: // Treat a response whose status is 0 as ...
6 years, 3 months ago (2014-09-22 08:38:20 UTC) #5
yhirano
On 2014/09/22 08:38:20, horo wrote: > https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc > File content/browser/service_worker/service_worker_url_request_job.cc (right): > > https://codereview.chromium.org/590043002/diff/20001/content/browser/service_worker/service_worker_url_request_job.cc#newcode384 > ...
6 years, 3 months ago (2014-09-22 08:41:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590043002/40001
6 years, 3 months ago (2014-09-22 21:37:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 79369b47e475ebb40785eca8bdc269b9c543ebf3
6 years, 3 months ago (2014-09-22 22:57:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:57:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8faf94721b6ec90f92404234f0c227e2e501c102
Cr-Commit-Position: refs/heads/master@{#296080}

Powered by Google App Engine
This is Rietveld 408576698