Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 590033002: Update mini_chromium to get close$NOCANCEL, and update GYP to keep up (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Update mini_chromium to get close$NOCANCEL, and update GYP to keep up. Update mini_chromium to 313bd83d6d9d, picking up: 313bd83d6d9d Use close$NOCANCEL on Mac, as in Chrome r23369. 15a69caf735f Add some things from base/synchronization: ConditionVariable and Lock. Also, udpate GYP to 46282cedf40f (r1977), picking up: r1977 android: Add a way to override build system variables. r1976 android: Don't emit useless info into generated makefiles. r1975 Fix indentation for emacs and add missing keyword. r1974 Changes ninja generator to only output empty names if not already output r1973 Changes the ninja generator to output phony targets for uninteresting targets r1972 Makes matching of build files work when absolute r1971 Support for custom NM/readelf binaries in your toolchain. r1970 android: Support host multilib builds. r1969 Makes analyzer output names of all executable target types r1968 android: Make buildbot able to use a custom manifest. r1967 ninja win: don't expect pdb to be generated when GenerateDebugInformation: false r1966 Makes the analyzer output the set of targets needing a build r1965 Removes old way to specify files to look for r1964 Provide a way to suppress implicit MIDL generation rules for actions r1963 Style changes for analyzer __ -> _ and lots of single newlines to double newlines. r1962 Changes for analyzer r1961 Pull in relevant targets when using xcode-ninja r1960 Guard against configurations without 'xcode_settings' r1959 Updates analyzer to output to a file R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4517d7c866065ebbf2cecbc2b7f792ca7905ad5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 04:04:26 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-22 16:36:29 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-22 17:18:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 4517d7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698