Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 590023002: Experimental app list: Remove page indicator. (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, kcarattini
Base URL:
https://chromium.googlesource.com/chromium/src.git@views-imagebutton-min-size
Project:
chromium
Visibility:
Public.

Description

Experimental app list: Remove page indicator. This is a partial revert of commit 6c4617f (r282586), "Experimental app list: Added a current page indicator to the launcher.". Latest mocks indicate the selected page by changing its icon to blue, rather than having a blue line above the icon. The reason we are removing this now is for spacing reasons -- we need to move the grey separator line up by 1px but the blue line can't be moved up unless we shrink the contents view. BUG=411775 Committed: https://crrev.com/a1fbd2bd021a98b47c5631186c10ad7001c7c851 Cr-Commit-Position: refs/heads/master@{#295928}

Patch Set 1 #

Patch Set 2 : Actually, don't remove the PaginationModelObserver. We'll need it soon. #

Patch Set 3 : Rebase. #

Total comments: 2

Patch Set 4 : Remove include app_list_constants.h and IWYU. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -59 lines) Patch
M ui/app_list/app_list_constants.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/contents_switcher_view.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/views/contents_switcher_view.cc View 1 2 3 4 chunks +3 lines, -50 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Matt Giuca
Sorry, Kendra, we're removing your page indicator. But the work you did on hooking ContentsSwitcherView ...
6 years, 3 months ago (2014-09-22 03:23:13 UTC) #2
calamity
lgtm https://codereview.chromium.org/590023002/diff/40001/ui/app_list/views/contents_switcher_view.cc File ui/app_list/views/contents_switcher_view.cc (right): https://codereview.chromium.org/590023002/diff/40001/ui/app_list/views/contents_switcher_view.cc#newcode7 ui/app_list/views/contents_switcher_view.cc:7: #include "ui/app_list/app_list_constants.h" I think you can remove this ...
6 years, 3 months ago (2014-09-22 05:51:44 UTC) #3
Matt Giuca
https://codereview.chromium.org/590023002/diff/40001/ui/app_list/views/contents_switcher_view.cc File ui/app_list/views/contents_switcher_view.cc (right): https://codereview.chromium.org/590023002/diff/40001/ui/app_list/views/contents_switcher_view.cc#newcode7 ui/app_list/views/contents_switcher_view.cc:7: #include "ui/app_list/app_list_constants.h" On 2014/09/22 05:51:43, calamity wrote: > I ...
6 years, 3 months ago (2014-09-22 06:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/590023002/60001
6 years, 3 months ago (2014-09-22 06:01:58 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 57e429518fdb43cfe56da99dda8b1ad53225a0ee
6 years, 3 months ago (2014-09-22 06:46:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 06:46:38 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a1fbd2bd021a98b47c5631186c10ad7001c7c851
Cr-Commit-Position: refs/heads/master@{#295928}

Powered by Google App Engine
This is Rietveld 408576698