Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 590001: Respect the SaveZoneInformation policy when marking downloaded files as unsaf... (Closed)

Created:
7 years, 9 months ago by Catalin Patulea
Modified:
2 years, 10 months ago
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Respect the SaveZoneInformation policy when marking downloaded files as unsafe. BUG=5719 TEST=Enable zone marking, download file, verify that it's marked unsafe. Disable zone marking, download file, verify that it is unmarked.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M chrome/browser/download/download_file.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/save_file.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/win_safe_util.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/win_safe_util.cc View 3 chunks +29 lines, -20 lines 0 comments Download
Trybot results:

Messages

Total messages: 9 (0 generated)
Nico
Passed the try servers. Cc'd people, can one of you take a look? CL's pretty ...
7 years, 9 months ago (2010-02-08 21:39:33 UTC) #1
abarth-chromium
I'll be able to look at this later this afternoon if someone doesn't get back ...
7 years, 9 months ago (2010-02-08 21:42:52 UTC) #2
Catalin Patulea
download_uitest.cc failed on Windows.. (it didn't find the zone info) I'm not exactly sure why ...
7 years, 9 months ago (2010-02-08 21:43:36 UTC) #3
abarth-chromium
This looks ok to me, but I'm not an expert on the COM part (which ...
7 years, 9 months ago (2010-02-09 02:02:03 UTC) #4
Catalin Patulea
I forgot to include a link to the build which thakis started for me and ...
7 years, 9 months ago (2010-02-09 02:12:01 UTC) #5
Glenn Wilson
On 2010/02/09 02:12:01, Catalin Patulea wrote: > I forgot to include a link to the ...
7 years, 9 months ago (2010-02-09 02:24:49 UTC) #6
Catalin Patulea
On 2010/02/09 02:24:49, Glenn Wilson wrote: > I've had a patch I've been trying to ...
7 years, 9 months ago (2010-02-09 02:56:59 UTC) #7
Glenn Wilson
On 2010/02/09 02:56:59, Catalin Patulea wrote: > On 2010/02/09 02:24:49, Glenn Wilson wrote: > > ...
7 years, 9 months ago (2010-02-09 15:15:59 UTC) #8
abarth-chromium
7 years, 9 months ago (2010-02-09 16:07:30 UTC) #9

          

Powered by Google App Engine
This is Rietveld efc10ee0f