content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 58993002: Fix crash when system retains an accessibility object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 58993002: Fix crash when system retains an accessibility object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: real fix Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 545ed0ce50ed3fb9224eba9b58a8014600dd4d4e..2b4e0dcc13d840a16e40c97220fb88ddd5d86e4f 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -1421,6 +1421,8 @@ NSDictionary* attributeToMethodNameMap = nil;

BrowserAccessibilityCocoa* hit = self;

for (BrowserAccessibilityCocoa* child in [self children]) {

+ if (!child->browserAccessibility_)

+ continue;

NSPoint origin = [child origin];

NSSize size = [[child size] sizeValue];

NSRect rect;

« no previous file with comments | « no previous file | no next file » | no next file with comments »