Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 589853002: Disable implicit conversions of scoped_refptr to T* on Mac. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable implicit conversions of scoped_refptr to T* on Mac. The implicit conversion has already been disabled for Linux and ChromeOS builds. https://codereview.chromium.org/510323002 explains the rationale for proceeding incrementally. BUG=110610 TBR=thakis@chromium.org Committed: https://crrev.com/ed3e65c71b7566004fc75da2799f1f9e7e4b299c Cr-Commit-Position: refs/heads/master@{#295889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/memory/ref_counted.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589853002/1
6 years, 3 months ago (2014-09-20 18:32:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15944)
6 years, 3 months ago (2014-09-20 20:08:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589853002/1
6 years, 3 months ago (2014-09-20 20:10:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4bbd71d39ac6446ba8a2e9e6213594b074d9c7b3
6 years, 3 months ago (2014-09-20 20:53:40 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed3e65c71b7566004fc75da2799f1f9e7e4b299c Cr-Commit-Position: refs/heads/master@{#295889}
6 years, 3 months ago (2014-09-20 20:54:15 UTC) #9
Nico
6 years, 3 months ago (2014-09-20 22:29:48 UTC) #10
Message was sent while issue was closed.
lgtm

Nice!!

Powered by Google App Engine
This is Rietveld 408576698