Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 589773002: r287585, repackage edition. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/clang/scripts/repackage.sh View 1 chunk +5 lines, -1 line 2 comments Download

Messages

Total messages: 6 (1 generated)
Nico
:-(
6 years, 3 months ago (2014-09-19 22:21:23 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31a161ac5a1ae04cd76dbdb4520c544708b65d58 Cr-Commit-Position: refs/heads/master@{#295793}
6 years, 3 months ago (2014-09-19 22:24:50 UTC) #3
Nico
Committed patchset #1 (id:1) manually as 31a161a (presubmit successful).
6 years, 3 months ago (2014-09-19 22:25:46 UTC) #4
hans
https://codereview.chromium.org/589773002/diff/1/tools/clang/scripts/repackage.sh File tools/clang/scripts/repackage.sh (right): https://codereview.chromium.org/589773002/diff/1/tools/clang/scripts/repackage.sh#newcode59 tools/clang/scripts/repackage.sh:59: tar zcf ${PDIR}_repack.tgz -C "$LLVM_TAR_DIR" bin include lib buildlog.txt ...
6 years, 3 months ago (2014-09-19 22:52:29 UTC) #5
Nico
6 years, 3 months ago (2014-09-19 23:01:28 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/589773002/diff/1/tools/clang/scripts/repackag...
File tools/clang/scripts/repackage.sh (right):

https://codereview.chromium.org/589773002/diff/1/tools/clang/scripts/repackag...
tools/clang/scripts/repackage.sh:59: tar zcf ${PDIR}_repack.tgz -C
"$LLVM_TAR_DIR" bin include lib buildlog.txt
On 2014/09/19 22:52:29, hans wrote:
> tar: include: Cannot stat: No such file or directory
> 
> :(

I think that's because our current package is broken (due the problem this cl is
fixing). In general, I'm hopeful-ish that this should work.

Powered by Google App Engine
This is Rietveld 408576698