Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4262)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 589753005: gn: Fix build issues blocking gfx from being built (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index ba25fe47397228e26c1993a4abcc5f25bc9aac6c..34bf92af6ccf515457a4a5039af6633296edd0a7 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -111,6 +111,8 @@ template("msvc_toolchain") {
dllname,
libname,
]
+ link_output = dllname
ckocagil 2014/09/21 02:05:05 These should be explicitly stated, otherwise it us
brettw 2014/09/21 02:55:00 Actually, I think both of these should be the .lib
ckocagil 2014/09/21 11:47:26 Done. But could you elaborate on how it doesn't wo
+ depend_output = libname
# The use of inputs_newline is to work around a fixed per-line buffer
# size in the linker.
rspfile_content = "{{libs}} {{solibs}} {{inputs_newline}} {{ldflags}}"
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | chrome/common/BUILD.gn » ('j') | third_party/libpng/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698