Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 58973004: Increase tolerance for touch-snapping near the screen edges (Closed)

Created:
7 years, 1 month ago by varkha
Modified:
7 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Increases tolerance for touch-snapping near the screen edges BUG=316645 TEST=ash_unittests --gtest_filter=*SystemGestureEventFilterTest.Drag*NearEdgeSnaps* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233978

Patch Set 1 #

Total comments: 1

Patch Set 2 : Increase tolerance for touch-snapping near the screen edges (test) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3 lines) Patch
M ash/wm/system_gesture_event_filter_unittest.cc View 1 3 chunks +59 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
varkha
+jamescook, Could you please take a look? This increases snapping or docking target for touch ...
7 years, 1 month ago (2013-11-08 17:43:53 UTC) #1
James Cook
lgtm
7 years, 1 month ago (2013-11-08 18:14:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/58973004/90001
7 years, 1 month ago (2013-11-08 18:56:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=187380
7 years, 1 month ago (2013-11-08 19:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/58973004/90001
7 years, 1 month ago (2013-11-08 19:44:39 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 20:43:24 UTC) #6
Message was sent while issue was closed.
Change committed as 233978

Powered by Google App Engine
This is Rietveld 408576698