Enable dark_resume_always workaround if the wake-on-packets flag is set

Enable dark_resume_always workaround if the wake-on-packets flag is set

The dark_resume_always workaround is necessary for testing
wake-on-packets functionality because the mechanism to actually query
the wakeup source is not ready yet.  This workaround tells the kernel to
always enter dark resume and rely on chrome and powerd to detect user
activity and transition into fully resumed.

BUG=414949
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>;

Committed: https://crrev.com/2faeee1528f5ebc1cec10aba595fdd100366aba0
Cr-Commit-Position: refs/heads/master@{#296082}

[Chirantan Ekbote, 2014-09-20 01:06:46]

chirantan@chromium.org changed reviewers:
+ derat@chromium.org, stevenjb@chromium.org

[Chirantan Ekbote, 2014-09-20 01:06:46]

Please take a look.

[Daniel Erat, 2014-09-21 14:49:31]

https://codereview.chromium.org/589723003/diff/1/chrome/browser/chromeos/chro...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/589723003/diff/1/chrome/browser/chromeos/chro...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:585:
base::WriteFile(base::FilePath(kDarkResumeAlwaysFile),
can you put this somewhere else instead of chrome_browser_main_chromeos.cc?

[Daniel Erat, 2014-09-21 14:49:54]

(specifically, somewhere else that's more scoped to this feature)

[Chirantan Ekbote, 2014-09-22 17:19:26]

On 2014/09/21 at 14:49:54, derat wrote:
> (specifically, somewhere else that's more scoped to this feature)

I could stick it in the LightBar class since that's already something that
depends on the flag and is also going to be removed before we launch.

[Daniel Erat, 2014-09-22 17:21:46]

On 2014/09/22 17:19:26, chirantan wrote:
> On 2014/09/21 at 14:49:54, derat wrote:
> > (specifically, somewhere else that's more scoped to this feature)
> 
> I could stick it in the LightBar class since that's already something that
> depends on the flag and is also going to be removed before we launch.

thanks, i think i'd prefer that (since chrome_browser_main_chromeos.cc is
already too full of random stuff)

[Chirantan Ekbote, 2014-09-22 19:44:51]

ptal

[Daniel Erat, 2014-09-22 19:52:00]

lgtm

https://codereview.chromium.org/589723003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/power/light_bar.cc (right):

https://codereview.chromium.org/589723003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/power/light_bar.cc:47: 
nit: delete extra blank line

[Chirantan Ekbote, 2014-09-22 19:57:55]

The CQ bit was checked by chirantan@chromium.org

[Chirantan Ekbote, 2014-09-22 19:58:04]

The CQ bit was unchecked by chirantan@chromium.org

[Chirantan Ekbote, 2014-09-22 19:58:21]

The CQ bit was checked by chirantan@chromium.org

[commit-bot: I haz the power, 2014-09-22 19:59:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589723003/40001

[commit-bot: I haz the power, 2014-09-22 22:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:00:57]

Exceeded time limit waiting for builds to trigger.

[Chirantan Ekbote, 2014-09-22 22:02:36]

The CQ bit was checked by chirantan@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589723003/40001

[commit-bot: I haz the power, 2014-09-22 22:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:13:46]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Chirantan Ekbote, 2014-09-22 22:15:09]

The CQ bit was checked by chirantan@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:16:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589723003/60001

[commit-bot: I haz the power, 2014-09-22 23:03:16]

Committed patchset #4 (id:60001) as d54a92021db53302d6824949dcfdaa1423d5f469

[commit-bot: I haz the power, 2014-09-22 23:04:09]

Patchset 4 (id:??) landed as
https://crrev.com/2faeee1528f5ebc1cec10aba595fdd100366aba0
Cr-Commit-Position: refs/heads/master@{#296082}

[Chirantan Ekbote, 2014-12-19 23:41:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/808783003/ by chirantan@chromium.org.

The reason for reverting is: Kernel changes have landed.  This workaround is no
longer needed..