Fix JS for proxy config UI

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: onc_data.js
 
 // NOTE(stevenjb): This code is in the process of being converted to be
 // compatible with the networkingPrivate extension API:
 // * The network property dictionaries are being converted to use ONC values.
 // * chrome.send calls will be replaced with an API object that simulates the
@@ skipping 425 matching lines @@
         event.value.controlledBy = 'policy';
       }
 
       return event;
     },
 
     /**
      * Update details page controls.
      */
     updateControls: function() {
+      // Note: onc may be undefined when called from a pref update before
+      // initialized in sendNetworkDetails.
       var onc = this.onc_;
-      if (onc == undefined)
-        return;  // May get called from a pref update before initialized.
 
       // Always show the ipconfig section. TODO(stevenjb): Improve the display
       // for unconnected networks. Currently the IP address fields may be
       // blank if the network is not connected.
       $('ipconfig-section').hidden = false;
       $('ipconfig-dns-section').hidden = false;
 
       // Network type related.
       updateHidden('#details-internet-page .cellular-details',
                    this.type_ != 'Cellular');
       updateHidden('#details-internet-page .wifi-details',
                    this.type_ != 'WiFi');
       updateHidden('#details-internet-page .wimax-details',
                    this.type_ != 'Wimax');
       updateHidden('#details-internet-page .vpn-details', this.type_ != 'VPN');
       updateHidden('#details-internet-page .proxy-details', !this.showProxy_);
 
       // Cellular
-      if (this.type_ == 'Cellular') {
+      if (onc && this.type_ == 'Cellular') {
         // Hide gsm/cdma specific elements.
         if (onc.getActiveValue('Cellular.Family') == 'GSM')
           updateHidden('#details-internet-page .cdma-only', true);
         else
           updateHidden('#details-internet-page .gsm-only', true);
       }
 
       // Wifi
 
       // Hide network tab for VPN.
       updateHidden('#details-internet-page .network-details',
                    this.type_ == 'VPN');
 
       // Password and shared.
-      var source = onc.getSource();
+      var source = onc ? onc.getSource() : 'None';
       var shared = (source == 'Device' || source == 'DevicePolicy');
+      var security = onc ? onc.getWiFiSecurity() : 'None';
       updateHidden('#details-internet-page #password-details',
-                   this.type_ != 'WiFi' || onc.getWiFiSecurity() == 'None');
+                   this.type_ != 'WiFi' || security == 'None');
       updateHidden('#details-internet-page #wifi-shared-network', !shared);
       updateHidden('#details-internet-page #prefer-network', source == 'None');
 
       // WiMAX.
       updateHidden('#details-internet-page #wimax-shared-network', !shared);
 
       // Proxy
       this.updateProxyBannerVisibility_();
       this.toggleSingleProxy_();
       if ($('manual-proxy').checked)
@@ skipping 1092 matching lines @@
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     PageManager.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });