Issue 589693002: Fix JS for proxy config UI

Issue 589693002: Fix JS for proxy config UI (Closed)

Created:
6 years, 3 months ago by stevenjb

Modified:
6 years, 3 months ago

Reviewers:
michaelpg

CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix JS for proxy config UI BUG=415697 Committed: https://crrev.com/1409716c29452510a262878e7f6f825d71c045c5 Cr-Commit-Position: refs/heads/master@{#295840}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/resources/options/chromeos/internet_detail.js	View		3 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 8 (2 generated)

michaelpg

Still not sure why the strings were missing from loadTimeData, but if everything works it ...

6 years, 3 months ago (2014-09-19 23:08:10 UTC) #3

stevenjb

On 2014/09/19 23:08:10, michaelpg wrote: > Still not sure why the strings were missing from ...

6 years, 3 months ago (2014-09-19 23:34:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589693002/1

6 years, 3 months ago (2014-09-19 23:36:15 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as fc816dac2bea52090e061064c972da804a7fb2f3

6 years, 3 months ago (2014-09-20 01:33:53 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-20 01:34:24 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1409716c29452510a262878e7f6f825d71c045c5
Cr-Commit-Position: refs/heads/master@{#295840}