Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 589663002: Make protobuf enums canonical for ReadState/WriteState/ConnectState. (Closed)

Created:
6 years, 3 months ago by Kevin M
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make protobuf enums canonical for ReadState/WriteState/ConnectState. Delete redundant non-proto ReadState/WriteState/ConnectState enums. Add cast protogen rule to extension registration deps. BUG= Committed: https://crrev.com/d61f0b96fc6068df740118c1fb185a027ddc1c96 Cr-Commit-Position: refs/heads/master@{#296003}

Patch Set 1 #

Patch Set 2 : Resync with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -502 lines) Patch
M extensions/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/api_registration.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D extensions/browser/api/cast_channel/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_auth_util_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D extensions/browser/api/cast_channel/cast_channel.proto View 1 chunk +0 lines, -91 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_framer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.h View 4 chunks +7 lines, -36 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.cc View 26 chunks +71 lines, -185 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/logger.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/logger_util.h View 1 chunk +6 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/logger_util.cc View 2 chunks +46 lines, -1 line 0 comments Download
D extensions/browser/api/cast_channel/logging.proto View 1 chunk +0 lines, -149 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +15 lines, -0 lines 0 comments Download
A + extensions/common/api/cast_channel/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/api/cast_channel/cast_channel.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/common/api/cast_channel/logging.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 1 3 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Kevin M
Was CL #576483003. Previous submission failed due to dangling path references breaking the build. The ...
6 years, 3 months ago (2014-09-19 18:37:42 UTC) #2
Ken Rockot(use gerrit already)
On 2014/09/19 18:37:42, kmarshall wrote: > Was CL #576483003. Previous submission failed due to dangling ...
6 years, 3 months ago (2014-09-19 22:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589663002/1
6 years, 3 months ago (2014-09-19 22:45:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58528) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/11436)
6 years, 3 months ago (2014-09-19 22:50:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589663002/20001
6 years, 3 months ago (2014-09-19 23:48:44 UTC) #9
Wez
Rubber-stamp LGTM For future reference, you can re-use the original CL for re-lands w/ minor ...
6 years, 3 months ago (2014-09-19 23:50:56 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-20 01:50:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589663002/20001
6 years, 3 months ago (2014-09-22 17:09:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1374b436d89acae16b35efb4e0ebe368daac48aa
6 years, 3 months ago (2014-09-22 17:10:39 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 17:11:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d61f0b96fc6068df740118c1fb185a027ddc1c96
Cr-Commit-Position: refs/heads/master@{#296003}

Powered by Google App Engine
This is Rietveld 408576698