Issue 589643003: cros: Clear secret when it is no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 589643003: cros: Clear secret when it is no longer needed. (Closed)

Created:
6 years, 3 months ago by xiyuan

Modified:
6 years, 3 months ago

Reviewers:
tbarzic

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, Nikita (slow), dzhioev (left Google)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

cros: Clear secret when it is no longer needed. BUG=416127 Committed: https://crrev.com/8ba4546fd0922508e212348f19dd2b624290c683 Cr-Commit-Position: refs/heads/master@{#295869}

Patch Set 1 #

Patch Set 2 : change empty secret DCHECK to fix browser_tests #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/login/session/user_session_manager.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589643003/20001

6 years, 3 months ago (2014-09-20 03:25:52 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as e93f47ff81b7540111190a7ecfeffe9bf33a2ea9

6 years, 3 months ago (2014-09-20 13:20:26 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-20 13:20:55 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/8ba4546fd0922508e212348f19dd2b624290c683
Cr-Commit-Position: refs/heads/master@{#295869}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages