Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 589633002: Only add pdb to isolate when fastbuild!=2. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M base/base_unittests.isolate View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser_tests.isolate View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/sync_integration_tests.isolate View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_unittests.isolate View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/net_unittests.isolate View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
jam
6 years, 3 months ago (2014-09-19 18:14:13 UTC) #2
jam
TBRing since breaking win dbg compile trybots.
6 years, 3 months ago (2014-09-19 18:15:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589633002/1
6 years, 3 months ago (2014-09-19 18:17:42 UTC) #5
scottmg
Thanks, maybe telemetry_gpu_test.isolate too? https://code.google.com/p/chromium/codesearch#search/&q=%5C.pdb%20file:.isolate&sq=package:chromium&type=cs lgtm
6 years, 3 months ago (2014-09-19 18:23:46 UTC) #6
scottmg
On 2014/09/19 18:23:46, scottmg wrote: > Thanks, maybe telemetry_gpu_test.isolate too? > > https://code.google.com/p/chromium/codesearch#search/&q=%5C.pdb%20file:.isolate&sq=package:chromium&type=cs > > ...
6 years, 3 months ago (2014-09-19 18:24:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589633002/40001
6 years, 3 months ago (2014-09-19 18:32:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589633002/40001
6 years, 3 months ago (2014-09-19 18:39:40 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/59e489093730a82ab3cf08bfb8ece9ac5a5ce292 Cr-Commit-Position: refs/heads/master@{#295754}
6 years, 3 months ago (2014-09-19 18:59:06 UTC) #15
jam
6 years, 3 months ago (2014-09-19 18:59:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 59e4890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698