Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 58963004: Removed GetActiveEntry refernces from print preview and zoom files in (Closed)

Created:
7 years, 1 month ago by jww
Modified:
7 years, 1 month ago
Reviewers:
Charlie Reis, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Removed GetActiveEntry refernces from print preview and zoom files in chrome/browser/ui. See also https://codereview.chromium.org/66993003/ for relevant LGTMs. BUG=273710 TBR=creis@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jww
7 years, 1 month ago (2013-11-16 05:00:01 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-16 05:01:24 UTC) #2
Charlie Reis
LGTM. You'll probably need to TBR sky for owners.
7 years, 1 month ago (2013-11-16 19:14:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/58963004/1
7 years, 1 month ago (2013-11-19 21:20:38 UTC) #4
sky
LGTM
7 years, 1 month ago (2013-11-19 22:37:10 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 03:58:53 UTC) #6
Message was sent while issue was closed.
Change committed as 236130

Powered by Google App Engine
This is Rietveld 408576698