IDL compiler: [ActivityLogging] for methods

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method) %}
 static void {{method.name}}Method(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {% if method.number_of_required_arguments %}
     if (UNLIKELY(info.Length() < {{method.number_of_required_arguments}})) {
         throwTypeError(ExceptionMessages::failedToExecute("{{method.name}}", "{{interface_name}}", ExceptionMessages::notEnoughArguments({{method.number_of_required_arguments}}, info.Length())), info.GetIsolate());
         return;
     }
     {% endif %}
@@ skipping 50 matching lines @@
         return;
     }
     {% endif %}
     {% endfor %}
     {{method.cpp_method}};
 }
 {% endmacro %}
 
 
 {##############################################################################}
-{% macro method_callback(method) %}
+{% macro method_callback(method, world_suffix) %}
 static void {{method.name}}MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMMethod");
+    {% if world_suffix in method.activity_logging_world_list %}
+    V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
+    if (contextData && contextData->activityLogger()) {
+        Vector<v8::Handle<v8::Value> > loggerArgs = toVectorOfArguments(info);

[haraken, 2013/11/05 06:27:37]

Shall we use toNativeArguments(info, 0), and then remove toVectorOfArguments()
from V8Bindings.h ? We don't want to have similar methods with different names
in V8Bindings.h.

[Nils Barth (inactive), 2013/11/05 06:40:57]

Sounds good; will do in a followup!

+        contextData->activityLogger()->log("{{interface_name}}.{{method.name}}", info.Length(), loggerArgs.data(), "Method");
+    }
+    {% endif %}
     {{cpp_class_name}}V8Internal::{{method.name}}Method(info);
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
 }
 {% endmacro %}