src/hydrogen.cc - Issue 589543002: Internalize if not yet internalized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 589543002: Internalize if not yet internalized (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index ae63db7d538cb23f2bb463accf63ca6cd52a09ac..e5a93a7bd5b1f4ec513e0427d54f033b0fdf5dce 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7138,6 +7138,10 @@ HValue* HOptimizedGraphBuilder::HandleKeyedElementAccess(

uint32_t array_index;

if (constant->IsString() &&

!Handle<String>::cast(constant)->AsArrayIndex(&array_index)) {

+ if (!constant->IsUniqueName()) {

+ constant = isolate()->factory()->InternalizeString(

+ Handle<String>::cast(constant));

+ }

HInstruction* instr =

BuildNamedAccess(access_type, expr->id(), return_id, expr, obj,

Handle<String>::cast(constant), val, false);

« no previous file with comments | « no previous file | no next file » | no next file with comments »