Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 58953005: Refactoring spellcheck-attribute.html to use async path for spellcheck (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
Reviewers:
tony, groby-ooo-7-16
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Refactoring spellcheck-attribute.html to use async path for spellcheck Deprecate synchronous spellchecking in spellcheck-attribute.html in a favor of its asynchronous option. BUG=295722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161898

Patch Set 1 #

Total comments: 2

Patch Set 2 : Get rid of duplicated elements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -78 lines) Patch
M LayoutTests/editing/spelling/spellcheck-attribute.html View 1 5 chunks +62 lines, -46 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-attribute-expected.txt View 1 1 chunk +24 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
grzegorz
If you aren't bored with another move of sync to async spellchecking in layout tests, ...
7 years, 1 month ago (2013-11-08 11:02:48 UTC) #1
groby-ooo-7-16
https://codereview.chromium.org/58953005/diff/1/LayoutTests/editing/spelling/spellcheck-attribute.html File LayoutTests/editing/spelling/spellcheck-attribute.html (right): https://codereview.chromium.org/58953005/diff/1/LayoutTests/editing/spelling/spellcheck-attribute.html#newcode18 LayoutTests/editing/spelling/spellcheck-attribute.html:18: <label>1.6.</label><input id="test1_6" type="text"></input><br/> I might be missing something, but ...
7 years, 1 month ago (2013-11-08 19:25:13 UTC) #2
grzegorz
https://codereview.chromium.org/58953005/diff/1/LayoutTests/editing/spelling/spellcheck-attribute.html File LayoutTests/editing/spelling/spellcheck-attribute.html (right): https://codereview.chromium.org/58953005/diff/1/LayoutTests/editing/spelling/spellcheck-attribute.html#newcode18 LayoutTests/editing/spelling/spellcheck-attribute.html:18: <label>1.6.</label><input id="test1_6" type="text"></input><br/> On 2013/11/08 19:25:13, groby wrote: > ...
7 years, 1 month ago (2013-11-12 09:24:46 UTC) #3
tony
LGTM
7 years, 1 month ago (2013-11-12 17:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/58953005/60001
7 years, 1 month ago (2013-11-12 17:37:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=16960
7 years, 1 month ago (2013-11-12 19:19:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/58953005/60001
7 years, 1 month ago (2013-11-13 08:39:51 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 09:35:15 UTC) #8
Message was sent while issue was closed.
Change committed as 161898

Powered by Google App Engine
This is Rietveld 408576698