Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 589523003: remove some unused strings (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove some unused strings BUG=386033, 365418 Committed: https://crrev.com/e193568d1bac055df23d45909ce38dbc97728be8 Cr-Commit-Position: refs/heads/master@{#295843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +0 lines, -70 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Evan Stade
6 years, 3 months ago (2014-09-19 23:20:11 UTC) #2
Lei Zhang
LGTM !
6 years, 3 months ago (2014-09-19 23:33:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589523003/1
6 years, 3 months ago (2014-09-19 23:58:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589523003/1
6 years, 3 months ago (2014-09-19 23:58:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/17432)
6 years, 3 months ago (2014-09-20 00:16:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589523003/1
6 years, 3 months ago (2014-09-20 00:25:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589523003/1
6 years, 3 months ago (2014-09-20 00:25:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 770c0d8072fbbb939200eacc409ec1d26942d663
6 years, 3 months ago (2014-09-20 02:03:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9810832fe3c3d49400ddd475b386d59a1eb38e91
6 years, 3 months ago (2014-09-20 02:03:27 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 02:03:54 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e193568d1bac055df23d45909ce38dbc97728be8
Cr-Commit-Position: refs/heads/master@{#295843}

Powered by Google App Engine
This is Rietveld 408576698