Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 589513003: Use libc++ by default on iOS (Closed)

Created:
6 years, 3 months ago by sdefresne
Modified:
6 years, 3 months ago
CC:
chromium-reviews, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use libc++ by default on iOS libc++ is the recommended C++ library for iOS development so use it by default when targeting iOS. clang ToT ships with all the required header and libraries to support compiling with -stdlib=libc++ so remove the exception. BUG=366744 Committed: https://crrev.com/7da3d8874ba759574edf778c58de024fe0974925 Cr-Commit-Position: refs/heads/master@{#295715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/common.gypi View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please have a look.
6 years, 3 months ago (2014-09-19 13:37:12 UTC) #2
rohitrao (ping after 24h)
LGTM
6 years, 3 months ago (2014-09-19 13:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589513003/1
6 years, 3 months ago (2014-09-19 15:16:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d3158a160587273002a8a92945fe05af412eb545
6 years, 3 months ago (2014-09-19 15:59:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:00:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7da3d8874ba759574edf778c58de024fe0974925
Cr-Commit-Position: refs/heads/master@{#295715}

Powered by Google App Engine
This is Rietveld 408576698