Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 589493002: Fix compilation with Xcode 6.0.1 (Closed)

Created:
6 years, 3 months ago by sdefresne
Modified:
6 years, 3 months ago
Reviewers:
droger, lliabraa
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation with Xcode 6.0.1 Apply Xcode 6.0 fix to all following versions of Xcode (it's great that gyp does support python string ordering). BUG=385030 Committed: https://crrev.com/f1994cefc7b38467ad408e79b1b8a1e3e4d50b5a Cr-Commit-Position: refs/heads/master@{#295699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/iossim/iossim.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sdefresne
PTAL
6 years, 3 months ago (2014-09-19 11:28:16 UTC) #2
sdefresne
+rohitrao for OWNERS
6 years, 3 months ago (2014-09-19 11:30:40 UTC) #4
droger
lgtm
6 years, 3 months ago (2014-09-19 11:32:46 UTC) #5
sdefresne
-rohitrao, +lliabraa for OWNERS
6 years, 3 months ago (2014-09-19 13:02:10 UTC) #7
lliabraa
lgtm thanks!
6 years, 3 months ago (2014-09-19 13:08:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589493002/1
6 years, 3 months ago (2014-09-19 13:09:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2c7624a1a23b2a2e59cbb3792b5f4a6f67bf437c
6 years, 3 months ago (2014-09-19 14:07:03 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 14:07:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1994cefc7b38467ad408e79b1b8a1e3e4d50b5a
Cr-Commit-Position: refs/heads/master@{#295699}

Powered by Google App Engine
This is Rietveld 408576698