Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 589463002: Code refactor related to WeakPtrFactory in content/browser module (Closed)

Created:
6 years, 3 months ago by krish
Modified:
6 years, 2 months ago
Reviewers:
lgombos, MRV, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing in the intialization order of WeakPtrFactory in content/browser module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/875dc1fdfcf23ff64f959f423117fc25fd05b4e4 Cr-Commit-Position: refs/heads/master@{#298383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
krish
sky@chromium.org: Please review changes in content/browser module
6 years, 2 months ago (2014-09-26 06:26:52 UTC) #3
krish
On 2014/09/26 06:26:52, krish wrote: > mailto:sky@chromium.org: Please review changes in > content/browser module PTAL
6 years, 2 months ago (2014-10-06 06:20:23 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-06 14:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589463002/1
6 years, 2 months ago (2014-10-07 03:42:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1381b3937cb871989a177dd7a397a37c424daed2
6 years, 2 months ago (2014-10-07 05:39:29 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:40:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/875dc1fdfcf23ff64f959f423117fc25fd05b4e4
Cr-Commit-Position: refs/heads/master@{#298383}

Powered by Google App Engine
This is Rietveld 408576698