Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1705)

Issue 58943003: Remove duplicated headers (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, philipj_slow, loislo+blink_chromium.org, jsbell, dgrogan, eustas+blink_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, alecflett, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, gavinp+prerender_chromium.org, aandrey+blink_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove duplicated headers from the implementation file that is included in the corresponding primary header file as well. As an example if MyClass.h includes "Dependency.h" than MyClass.cpp no longer needs to include "Dependency.h". BUG=317231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M Source/web/EventListenerWrapper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/GeolocationClientProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/NotificationPresenterImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PopupContainer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/PrerendererClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/SpeechInputClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/SpeechRecognitionClientProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebEntities.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebFontImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebIDBDatabaseCallbacksImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebInputEventConversion.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/web/WebSocketImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/web/WebWorkerClientImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/URLTestHelpers.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
I have a script that does the work. I plan to upload CLs for each ...
7 years, 1 month ago (2013-11-10 05:37:01 UTC) #1
eseidel
The idea is OK. It can be hard to make this kind of change as ...
7 years, 1 month ago (2013-11-10 09:02:42 UTC) #2
eseidel
lgtm If it builds everywhere.
7 years, 1 month ago (2013-11-10 09:03:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/58943003/1
7 years, 1 month ago (2013-11-10 09:03:16 UTC) #4
eseidel
There was also (a while ago?) an "include what you use" effort. It's much better ...
7 years, 1 month ago (2013-11-10 09:04:11 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 10:45:30 UTC) #6
Message was sent while issue was closed.
Change committed as 161696

Powered by Google App Engine
This is Rietveld 408576698