Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: ui/views/accessible_pane_view.h

Issue 589413002: Fix WeakPtrFactory member ordering in ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unwanted header inclusions Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/keyboard_controller.h ('k') | ui/views/accessible_pane_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessible_pane_view.h
diff --git a/ui/views/accessible_pane_view.h b/ui/views/accessible_pane_view.h
index cde84a752439301b46cec509fc73baff36c4a260..11ea4486b64d638fd1a34a642bfa1cd335dd6120 100644
--- a/ui/views/accessible_pane_view.h
+++ b/ui/views/accessible_pane_view.h
@@ -101,8 +101,6 @@ class VIEWS_EXPORT AccessiblePaneView : public View,
// is known where to return to.
bool allow_deactivate_on_esc_;
- base::WeakPtrFactory<AccessiblePaneView> method_factory_;
-
// Save the focus manager rather than calling GetFocusManager(),
// so that we can remove focus listeners in the destructor.
FocusManager* focus_manager_;
@@ -124,6 +122,8 @@ class VIEWS_EXPORT AccessiblePaneView : public View,
friend class AccessiblePaneViewFocusSearch;
+ base::WeakPtrFactory<AccessiblePaneView> method_factory_;
+
DISALLOW_COPY_AND_ASSIGN(AccessiblePaneView);
};
« no previous file with comments | « ui/keyboard/keyboard_controller.h ('k') | ui/views/accessible_pane_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698