Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: ui/keyboard/keyboard_controller.h

Issue 589413002: Fix WeakPtrFactory member ordering in ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unwanted header inclusions Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/client/screen_position_client.cc ('k') | ui/views/accessible_pane_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_controller.h
diff --git a/ui/keyboard/keyboard_controller.h b/ui/keyboard/keyboard_controller.h
index c4dcfff0c4613d925679027e8d63015dc70fbda0..fbb1bdcfa99af50ce67ee6cbaecace3bac449cc6 100644
--- a/ui/keyboard/keyboard_controller.h
+++ b/ui/keyboard/keyboard_controller.h
@@ -166,13 +166,13 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
ObserverList<KeyboardControllerObserver> observer_list_;
- base::WeakPtrFactory<KeyboardController> weak_factory_;
-
// The currently used keyboard position.
gfx::Rect current_keyboard_bounds_;
static KeyboardController* instance_;
+ base::WeakPtrFactory<KeyboardController> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(KeyboardController);
};
« no previous file with comments | « ui/aura/client/screen_position_client.cc ('k') | ui/views/accessible_pane_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698