Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 589413002: Fix WeakPtrFactory member ordering in ui (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in ui Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/73b5ddebad0ec50c82e1551d77f34f9e5f3541e1 Cr-Commit-Position: refs/heads/master@{#296468}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unwanted header inclusions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -27 lines) Patch
M ui/aura/client/screen_position_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/accessible_pane_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/accessible_pane_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/base_focus_rules.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/core/shadow_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/core/window_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
MRV
Very few files left, after that we can incorporate changes for presubmit. PTAL
6 years, 3 months ago (2014-09-23 13:49:53 UTC) #2
sky
https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc File ui/aura/client/screen_position_client.cc (right): https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc#newcode7 ui/aura/client/screen_position_client.cc:7: //#include "ui/aura/window_event_dispatcher.h" Fix this.
6 years, 3 months ago (2014-09-23 21:40:40 UTC) #3
MRV
On 2014/09/23 21:40:40, sky wrote: > https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc > File ui/aura/client/screen_position_client.cc (right): > > https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc#newcode7 > ...
6 years, 3 months ago (2014-09-24 02:47:45 UTC) #4
MRV
PTAL https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc File ui/aura/client/screen_position_client.cc (right): https://codereview.chromium.org/589413002/diff/1/ui/aura/client/screen_position_client.cc#newcode7 ui/aura/client/screen_position_client.cc:7: //#include "ui/aura/window_event_dispatcher.h" On 2014/09/23 21:40:40, sky wrote: > ...
6 years, 3 months ago (2014-09-24 02:47:57 UTC) #5
sky
LGTM
6 years, 3 months ago (2014-09-24 14:31:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589413002/20001
6 years, 3 months ago (2014-09-24 17:18:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0e3e8d7f6b654224ff7a00a9daa27fc00b63485a
6 years, 3 months ago (2014-09-24 18:22:01 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/73b5ddebad0ec50c82e1551d77f34f9e5f3541e1 Cr-Commit-Position: refs/heads/master@{#296468}
6 years, 3 months ago (2014-09-24 18:22:41 UTC) #10
MRV
6 years, 2 months ago (2014-09-25 01:57:53 UTC) #11
Message was sent while issue was closed.
On 2014/09/24 14:31:14, sky wrote:
> LGTM

Thanks mr.sky for lgtm.

Powered by Google App Engine
This is Rietveld 408576698