Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2501)

Unified Diff: base/command_line_unittest.cc

Issue 589393002: CommandLineTest.ProgramQuotes: Fix crash-prone test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line_unittest.cc
diff --git a/base/command_line_unittest.cc b/base/command_line_unittest.cc
index 06c5006505a2c8e592724fb6fdc169b28a627899..8aed618858ebc8606aebedf1af0763fd70c0692c 100644
--- a/base/command_line_unittest.cc
+++ b/base/command_line_unittest.cc
@@ -348,10 +348,7 @@ TEST(CommandLineTest, ProgramQuotes) {
// Check that quotes are added to command line string paths containing spaces.
CommandLine::StringType cmd_string(cl_program_path.GetCommandLineString());
- CommandLine::StringType program_string(cl_program_path.GetProgram().value());
- EXPECT_EQ('"', cmd_string[0]);
- EXPECT_EQ(program_string, cmd_string.substr(1, program_string.length()));
- EXPECT_EQ('"', cmd_string[program_string.length() + 1]);
+ EXPECT_EQ(L"\"Program Path\"", cmd_string);
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698