Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 589393002: CommandLineTest.ProgramQuotes: Fix crash-prone test. (Closed)

Created:
6 years, 2 months ago by Matt Giuca
Modified:
6 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, msw, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CommandLineTest.ProgramQuotes: Fix crash-prone test. Previously, this test would crash if the output wasn't quoted properly (since it assumes that cmd_string.length() >= program_string.length() + 2). Instead, directly compare the string with the expected output. This also guards against the possibility of mis-constructing the expected string. Committed: https://crrev.com/b937b24239d36fb4cdfeb98b2db818e4304dd8b4 Cr-Commit-Position: refs/heads/master@{#296350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M base/command_line_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
6 years, 2 months ago (2014-09-23 08:28:28 UTC) #2
Mark Mentovai
LGTM
6 years, 2 months ago (2014-09-23 12:25:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589393002/1
6 years, 2 months ago (2014-09-24 04:19:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ba61e7ee5e35facf09aa99b5988b56ff7d87db3a
6 years, 2 months ago (2014-09-24 04:55:37 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 04:56:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b937b24239d36fb4cdfeb98b2db818e4304dd8b4
Cr-Commit-Position: refs/heads/master@{#296350}

Powered by Google App Engine
This is Rietveld 408576698